Commit Graph
38 Commits
Author SHA1 Message Date
morenolandGitHub d8d751920b Merge pull request #42 from morenol/python-development
Derive clone for NB Parameters structs,
2020-12-18 14:52:18 -04:00
Luis Moreno c9eb94ba93 Derive clone for NB Parameters 2020-12-18 00:39:54 -04:00
morenolandGitHub 413f1a0f55 Merge pull request #39 from morenol/lmm/update_ndarray
fix: Update ndarray version
2020-12-16 18:38:00 -04:00
Luis Moreno 505f495445 fix: Update ndarray version 2020-12-16 00:20:07 -04:00
morenolandGitHub 53351b2ece fix needless-range and clippy::ptr_arg warnings. (#36)
* Fix needless for loop range

* Do not ignore clippy::ptr_arg
2020-12-11 16:52:39 -04:00
morenolandGitHub 2650416235 Add benches for GNB (#33)
* Add benches for GNB

* use [black_box](https://github.com/bheisler/criterion.rs/blob/master/book/src/faq.md#when-should-i-use-criterionblack_box)
2020-12-04 20:46:36 -04:00
morenolandGitHub f0b348dd6e feat: BernoulliNB (#31)
* feat: BernoulliNB

* Move preprocessing to a trait in linalg/stats.rs
2020-12-04 20:45:40 -04:00
morenolandGitHub 4720a3a4eb MultinomialNB (#32)
feat: add MultinomialNB
2020-12-03 09:51:33 -04:00
morenolandGitHub 89a5136191 Change implementation of to_row_vector for nalgebra (#34)
* Add failing test

* Change implementation of to_row_vector for nalgebra
2020-11-25 14:39:02 -04:00
morenolandGitHub 9db993939e Add serde to CategoricalNB (#30)
* Add serde to CategoricalNB

* Implement PartialEq for CategoricalNBDistribution
2020-11-19 16:07:10 -04:00
morenolandGitHub ad3ac49dde Implement GaussianNB (#27)
* feat: Add GaussianNB
2020-11-19 14:19:22 -04:00
morenolandGitHub 72e9f8293f Use log likelihood to make calculations more stable (#28)
* Use log likelihood to make calculations more stable

* Fix problem with class_count in categoricalnb

* Use a similar approach to the one used in scikitlearn to define which are the possible categories of each feature.
2020-11-16 23:56:50 -04:00
morenolandGitHub aeddbc8a21 Merge pull request #25 from morenol/lmm/utils
Add capability to convert a slice to a BaseVector
2020-11-12 17:49:29 -04:00
Luis Moreno 6587ac032b Rename to from_array 2020-11-11 22:23:56 -04:00
Luis Moreno 49487bccd3 Rename trait function 2020-11-11 22:10:01 -04:00
Luis Moreno 900078cb04 Implement abstract method to convert a slice to a BaseVector, Implement RealNumberVector over BaseVector instead of over Vec<T> 2020-11-11 22:10:01 -04:00
morenolandGitHub b86c553bb1 Merge pull request #24 from morenol/lmm/clippy_ci
Add clippy CI job
2020-11-11 17:11:52 -04:00
Luis Moreno f46d3ba94c Address feedback 2020-11-10 21:24:08 -04:00
Luis Moreno 85d2ecd1c9 Fix clippy errors after --all-features was enabled 2020-11-10 21:24:04 -04:00
126b306681 Update .circleci/config.yml
Co-authored-by: VolodymyrOrlov <volodymyr.orlov@gmail.com>
2020-11-10 20:50:41 -04:00
Luis Moreno 18df9c758c Fix clippy::map_entry 2020-11-10 00:36:54 -04:00
Luis Moreno d620f225ee Fix new warnings after rustup update 2020-11-10 00:20:26 -04:00
Luis Moreno c756496b71 Fix clippy::len_without_is_empty 2020-11-09 16:36:43 -04:00
morenolandGitHub 3d4d5f64f6 feat: add Naive Bayes and CategoricalNB (#15)
* feat: Implement Naive Bayes classifier

* Implement CategoricalNB
2020-11-09 15:54:27 -04:00
Luis Moreno 5e887634db Fix clippy::comparison_chain 2020-11-09 00:02:22 -04:00
Luis Moreno 3c1969bdf5 Fix clippy::needless_lifetimes 2020-11-08 23:59:28 -04:00
Luis Moreno 0c35adf76a Fix clippy::let_and_return 2020-11-08 23:26:22 -04:00
Luis Moreno dd2864abe7 Fix clippy::extra_unused_lifetimes 2020-11-08 23:24:53 -04:00
Luis Moreno b780e0c289 Fix clippy::unnecessary_mut_passed 2020-11-08 23:22:18 -04:00
Luis Moreno 513d916580 Fix clippy::tabs_in_doc_comments 2020-11-08 23:20:22 -04:00
Luis Moreno 43584e14e5 Fix clippy::or_fun_call 2020-11-08 23:18:29 -04:00
Luis Moreno 4d75af6703 Allow temporally the warnings that are currently failing 2020-11-08 20:59:27 -04:00
Luis Moreno 8a2da00665 Fail in case of clippy warning 2020-11-08 20:58:47 -04:00
Luis Moreno 54886ebd72 Fix rust-2018-idioms warnings 2020-11-08 20:24:08 -04:00
Luis Moreno ea5de9758a Add -Drust-2018-idioms to clippy 2020-11-08 19:46:37 -04:00
Luis Moreno 860056c3ba Run: cargo clippy --fix -Z unstable-options and cargo fmt 2020-11-08 19:39:11 -04:00
Luis Moreno 8281a1620e Fix clippy errors 2020-11-06 23:17:33 -04:00
Luis Moreno ba03ef4678 Add clippy CI job 2020-11-06 23:17:22 -04:00