From 8281a1620ebbef9e527408f4813319288e69d9fe Mon Sep 17 00:00:00 2001 From: Luis Moreno Date: Fri, 6 Nov 2020 20:24:14 -0400 Subject: [PATCH] Fix clippy errors --- src/algorithm/neighbour/cover_tree.rs | 2 +- src/cluster/kmeans.rs | 2 +- src/dataset/mod.rs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/algorithm/neighbour/cover_tree.rs b/src/algorithm/neighbour/cover_tree.rs index da870d2..bbd7254 100644 --- a/src/algorithm/neighbour/cover_tree.rs +++ b/src/algorithm/neighbour/cover_tree.rs @@ -101,7 +101,7 @@ impl> CoverTree /// * `p` - look for k nearest points to `p` /// * `k` - the number of nearest neighbors to return pub fn find(&self, p: &T, k: usize) -> Result, Failed> { - if k <= 0 { + if k == 0 { return Err(Failed::because(FailedError::FindFailed, "k should be > 0")); } diff --git a/src/cluster/kmeans.rs b/src/cluster/kmeans.rs index eff65aa..278024f 100644 --- a/src/cluster/kmeans.rs +++ b/src/cluster/kmeans.rs @@ -129,7 +129,7 @@ impl KMeans { return Err(Failed::fit(&format!("invalid number of clusters: {}", k))); } - if parameters.max_iter <= 0 { + if parameters.max_iter == 0 { return Err(Failed::fit(&format!( "invalid maximum number of iterations: {}", parameters.max_iter diff --git a/src/dataset/mod.rs b/src/dataset/mod.rs index bfcd1c9..85829fe 100644 --- a/src/dataset/mod.rs +++ b/src/dataset/mod.rs @@ -56,8 +56,8 @@ pub(crate) fn serialize_data( ) -> Result<(), io::Error> { match File::create(filename) { Ok(mut file) => { - file.write(&dataset.num_features.to_le_bytes())?; - file.write(&dataset.num_samples.to_le_bytes())?; + file.write_all(&dataset.num_features.to_le_bytes())?; + file.write_all(&dataset.num_samples.to_le_bytes())?; let x: Vec = dataset .data .iter()