work/smartcore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix clippy (#276)

Browse Source 
Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
This commit is contained in:
morenol
2024-02-25 00:17:30 -05:00
committed by GitHub
parent 4eadd16ce4
commit 80a93c1a0e
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/linalg/basic/matrix.rs
+2 -2
View File
@@ -193,11 +193,11 @@ impl<T: Debug + Display + Copy + Sized> DenseMatrix<T> {
/// New instance of `DenseMatrix` from 2d array. /// New instance of `DenseMatrix` from 2d array.
pub fn from_2d_array(values: &[&[T]]) -> Self { pub fn from_2d_array(values: &[&[T]]) -> Self {
DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect()) DenseMatrix::from_2d_vec(&values.iter().map(|row| Vec::from(*row)).collect::<Vec<_>>())
} }
/// New instance of `DenseMatrix` from 2d vector. /// New instance of `DenseMatrix` from 2d vector.
pub fn from_2d_vec(values: &Vec<Vec<T>>) -> Self { pub fn from_2d_vec(values: &[Vec<T>]) -> Self {
let nrows = values.len(); let nrows = values.len();
let ncols = values let ncols = values
.first() .first()
src/preprocessing/numerical.rs
+5 -5
View File
@@ -197,11 +197,11 @@ mod tests {
fn combine_three_columns() { fn combine_three_columns() {
assert_eq!( assert_eq!(
build_matrix_from_columns(vec![ build_matrix_from_columns(vec![
DenseMatrix::from_2d_vec(&vec![vec![1.0], vec![1.0], vec![1.0],]), DenseMatrix::from_2d_vec(&[vec![1.0], vec![1.0], vec![1.0]]),
DenseMatrix::from_2d_vec(&vec![vec![2.0], vec![2.0], vec![2.0],]), DenseMatrix::from_2d_vec(&[vec![2.0], vec![2.0], vec![2.0]]),
DenseMatrix::from_2d_vec(&vec![vec![3.0], vec![3.0], vec![3.0],]) DenseMatrix::from_2d_vec(&[vec![3.0], vec![3.0], vec![3.0]])
]), ]),
Some(DenseMatrix::from_2d_vec(&vec![ Some(DenseMatrix::from_2d_vec(&[
vec![1.0, 2.0, 3.0], vec![1.0, 2.0, 3.0],
vec![1.0, 2.0, 3.0], vec![1.0, 2.0, 3.0],
vec![1.0, 2.0, 3.0] vec![1.0, 2.0, 3.0]
@@ -365,7 +365,7 @@ mod tests {
); );
assert!( assert!(
&DenseMatrix::<f64>::from_2d_vec(&vec![fitted_scaler.stds]).approximate_eq( &DenseMatrix::<f64>::from_2d_vec(&[fitted_scaler.stds]).approximate_eq(
&DenseMatrix::from_2d_array(&[&[ &DenseMatrix::from_2d_array(&[&[
0.29426447500954, 0.29426447500954,
0.16758497615485, 0.16758497615485,