From d9814c0918e1e9ee18693d06682a5ed801ee3a27 Mon Sep 17 00:00:00 2001 From: Luis Moreno Date: Tue, 27 Apr 2021 09:32:01 -0400 Subject: [PATCH] style(lint): fix clippy warnings --- src/algorithm/neighbour/cover_tree.rs | 3 +-- src/lib.rs | 3 ++- src/linalg/naive/dense_matrix.rs | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/algorithm/neighbour/cover_tree.rs b/src/algorithm/neighbour/cover_tree.rs index 9c5c806..bceb897 100644 --- a/src/algorithm/neighbour/cover_tree.rs +++ b/src/algorithm/neighbour/cover_tree.rs @@ -316,8 +316,7 @@ impl> CoverTree point_set.append(&mut far); child } else { - let mut children: Vec> = Vec::new(); - children.push(child); + let mut children: Vec> = vec![child]; let mut new_point_set: Vec> = Vec::new(); let mut new_consumed_set: Vec> = Vec::new(); diff --git a/src/lib.rs b/src/lib.rs index c7c99c8..c117039 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -2,7 +2,8 @@ clippy::type_complexity, clippy::too_many_arguments, clippy::many_single_char_names, - clippy::unnecessary_wraps + clippy::unnecessary_wraps, + clippy::upper_case_acronyms )] #![warn(missing_docs)] #![warn(missing_doc_code_examples)] diff --git a/src/linalg/naive/dense_matrix.rs b/src/linalg/naive/dense_matrix.rs index 4faa77d..34c8259 100644 --- a/src/linalg/naive/dense_matrix.rs +++ b/src/linalg/naive/dense_matrix.rs @@ -524,9 +524,9 @@ impl PartialEq for DenseMatrix { } } -impl Into> for DenseMatrix { - fn into(self) -> Vec { - self.values +impl From> for Vec { + fn from(dense_matrix: DenseMatrix) -> Vec { + dense_matrix.values } }