work/smartcore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix rust-2018-idioms warnings

Browse Source
This commit is contained in:
Luis Moreno
2020-11-08 20:24:08 -04:00
parent ea5de9758a
commit 54886ebd72
15 changed files with 29 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tree/decision_tree_classifier.rs
+3 -3
View File
@@ -334,7 +334,7 @@ impl<T: RealNumber> DecisionTreeClassifier<T> {
let mut visitor = NodeVisitor::<T, M>::new(0, samples, &order, &x, &yi, 1);
let mut visitor_queue: LinkedList<NodeVisitor<T, M>> = LinkedList::new();
let mut visitor_queue: LinkedList<NodeVisitor<'_, T, M>> = LinkedList::new();
if tree.find_best_cutoff(&mut visitor, mtry) {
visitor_queue.push_back(visitor);
@@ -392,7 +392,7 @@ impl<T: RealNumber> DecisionTreeClassifier<T> {
fn find_best_cutoff<M: Matrix<T>>(
&mut self,
visitor: &mut NodeVisitor<T, M>,
visitor: &mut NodeVisitor<'_, T, M>,
mtry: usize,
) -> bool {
let (n_rows, n_attr) = visitor.x.shape();
@@ -455,7 +455,7 @@ impl<T: RealNumber> DecisionTreeClassifier<T> {
fn find_best_split<M: Matrix<T>>(
&mut self,
visitor: &mut NodeVisitor<T, M>,
visitor: &mut NodeVisitor<'_, T, M>,
n: usize,
count: &Vec<usize>,
false_count: &mut Vec<usize>,
src/tree/decision_tree_regressor.rs
+3 -3
View File
@@ -240,7 +240,7 @@ impl<T: RealNumber> DecisionTreeRegressor<T> {
let mut visitor = NodeVisitor::<T, M>::new(0, samples, &order, &x, &y_m, 1);
let mut visitor_queue: LinkedList<NodeVisitor<T, M>> = LinkedList::new();
let mut visitor_queue: LinkedList<NodeVisitor<'_, T, M>> = LinkedList::new();
if tree.find_best_cutoff(&mut visitor, mtry) {
visitor_queue.push_back(visitor);
@@ -298,7 +298,7 @@ impl<T: RealNumber> DecisionTreeRegressor<T> {
fn find_best_cutoff<M: Matrix<T>>(
&mut self,
visitor: &mut NodeVisitor<T, M>,
visitor: &mut NodeVisitor<'_, T, M>,
mtry: usize,
) -> bool {
let (_, n_attr) = visitor.x.shape();
@@ -332,7 +332,7 @@ impl<T: RealNumber> DecisionTreeRegressor<T> {
fn find_best_split<M: Matrix<T>>(
&mut self,
visitor: &mut NodeVisitor<T, M>,
visitor: &mut NodeVisitor<'_, T, M>,
n: usize,
sum: T,
parent_gain: T,