fix needless-range and clippy::ptr_arg warnings. (#36)

* Fix needless for loop range * Do not ignore clippy::ptr_arg
2020-12-11 16:52:39 -04:00
parent 2650416235
commit 53351b2ece
27 changed files with 208 additions and 219 deletions
@@ -119,9 +119,9 @@ impl<T: RealNumber, D: Distance<Vec<T>, T>> KNNClassifier<T, D> {
        let mut yi: Vec<usize> = vec![0; y_n];
        let classes = y_m.unique();

-        for i in 0..y_n {
+        for (i, yi_i) in yi.iter_mut().enumerate().take(y_n) {
            let yc = y_m.get(0, i);
-            yi[i] = classes.iter().position(|c| yc == *c).unwrap();
+            *yi_i = classes.iter().position(|c| yc == *c).unwrap();
        }

        if x_n != y_n {