Merge potential next release v0.4 (#187) Breaking Changes

* First draft of the new n-dimensional arrays + NB use case
* Improves default implementation of multiple Array methods
* Refactors tree methods
* Adds matrix decomposition routines
* Adds matrix decomposition methods to ndarray and nalgebra bindings
* Refactoring + linear regression now uses array2
* Ridge & Linear regression
* LBFGS optimizer & logistic regression
* LBFGS optimizer & logistic regression
* Changes linear methods, metrics and model selection methods to new n-dimensional arrays
* Switches KNN and clustering algorithms to new n-d array layer
* Refactors distance metrics
* Optimizes knn and clustering methods
* Refactors metrics module
* Switches decomposition methods to n-dimensional arrays
* Linalg refactoring - cleanup rng merge (#172)
* Remove legacy DenseMatrix and BaseMatrix implementation. Port the new Number, FloatNumber and Array implementation into module structure.
* Exclude AUC metrics. Needs reimplementation
* Improve developers walkthrough

New traits system in place at `src/numbers` and `src/linalg`
Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

* Provide SupervisedEstimator with a constructor to avoid explicit dynamical box allocation in 'cross_validate' and 'cross_validate_predict' as required by the use of 'dyn' as per Rust 2021
* Implement getters to use as_ref() in src/neighbors
* Implement getters to use as_ref() in src/naive_bayes
* Implement getters to use as_ref() in src/linear
* Add Clone to src/naive_bayes
* Change signature for cross_validate and other model_selection functions to abide to use of dyn in Rust 2021
* Implement ndarray-bindings. Remove FloatNumber from implementations
* Drop nalgebra-bindings support (as decided in conf-call to go for ndarray)
* Remove benches. Benches will have their own repo at smartcore-benches
* Implement SVC
* Implement SVC serialization. Move search parameters in dedicated module
* Implement SVR. Definitely too slow
* Fix compilation issues for wasm (#202)

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
* Fix tests (#203)

* Port linalg/traits/stats.rs
* Improve methods naming
* Improve Display for DenseMatrix

Co-authored-by: Montana Low <montanalow@users.noreply.github.com>
Co-authored-by: VolodymyrOrlov <volodymyr.orlov@gmail.com>

src/metrics/recall.rs

@@ -10,67 +10,85 @@
 //!
 //! ```
 //! use smartcore::metrics::recall::Recall;
+//! use smartcore::metrics::Metrics;
 //! let y_pred: Vec<f64> = vec![0., 1., 1., 0.];
 //! let y_true: Vec<f64> = vec![0., 0., 1., 1.];
 //!
-//! let score: f64 = Recall {}.get_score(&y_pred, &y_true);
+//! let score: f64 = Recall::new().get_score(&y_pred, &y_true);
 //! ```
 //!
 //! <script src="https://polyfill.io/v3/polyfill.min.js?features=es6"></script>
 //! <script id="MathJax-script" async src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js"></script>
+
 use std::collections::HashSet;
 use std::convert::TryInto;
+use std::marker::PhantomData;
 
 #[cfg(feature = "serde")]
 use serde::{Deserialize, Serialize};
 
-use crate::linalg::BaseVector;
-use crate::math::num::RealNumber;
+use crate::linalg::basic::arrays::ArrayView1;
+use crate::numbers::realnum::RealNumber;
+
+use crate::metrics::Metrics;
 
 /// Recall metric.
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[derive(Debug)]
-pub struct Recall {}
+pub struct Recall<T> {
+    _phantom: PhantomData<T>,
+}
 
-impl Recall {
+impl<T: RealNumber> Metrics<T> for Recall<T> {
+    /// create a typed object to call Recall functions
+    fn new() -> Self {
+        Self {
+            _phantom: PhantomData,
+        }
+    }
+    fn new_with(_parameter: f64) -> Self {
+        Self {
+            _phantom: PhantomData,
+        }
+    }
     /// Calculated recall score
     /// * `y_true` - cround truth (correct) labels.
     /// * `y_pred` - predicted labels, as returned by a classifier.
-    pub fn get_score<T: RealNumber, V: BaseVector<T>>(&self, y_true: &V, y_pred: &V) -> T {
-        if y_true.len() != y_pred.len() {
+    fn get_score(&self, y_true: &dyn ArrayView1<T>, y_pred: &dyn ArrayView1<T>) -> f64 {
+        if y_true.shape() != y_pred.shape() {
             panic!(
                 "The vector sizes don't match: {} != {}",
-                y_true.len(),
-                y_pred.len()
+                y_true.shape(),
+                y_pred.shape()
             );
         }
 
         let mut classes = HashSet::new();
-        for i in 0..y_true.len() {
+        for i in 0..y_true.shape() {
             classes.insert(y_true.get(i).to_f64_bits());
         }
         let classes: i64 = classes.len().try_into().unwrap();
 
         let mut tp = 0;
         let mut fne = 0;
-        for i in 0..y_true.len() {
+        for i in 0..y_true.shape() {
             if y_pred.get(i) == y_true.get(i) {
                 if classes == 2 {
-                    if y_true.get(i) == T::one() {
+                    if *y_true.get(i) == T::one() {
                         tp += 1;
                     }
                 } else {
                     tp += 1;
                 }
             } else if classes == 2 {
-                if y_true.get(i) != T::one() {
+                if *y_true.get(i) != T::one() {
                     fne += 1;
                 }
             } else {
                 fne += 1;
             }
         }
-        T::from_i64(tp).unwrap() / (T::from_i64(tp).unwrap() + T::from_i64(fne).unwrap())
+        tp as f64 / (tp as f64 + fne as f64)
     }
 }
 
@@ -84,8 +102,8 @@ mod tests {
         let y_true: Vec<f64> = vec![0., 1., 1., 0.];
         let y_pred: Vec<f64> = vec![0., 0., 1., 1.];
 
-        let score1: f64 = Recall {}.get_score(&y_pred, &y_true);
-        let score2: f64 = Recall {}.get_score(&y_pred, &y_pred);
+        let score1: f64 = Recall::new().get_score(&y_pred, &y_true);
+        let score2: f64 = Recall::new().get_score(&y_pred, &y_pred);
 
         assert!((score1 - 0.5).abs() < 1e-8);
         assert!((score2 - 1.0).abs() < 1e-8);
@@ -93,8 +111,8 @@ mod tests {
         let y_pred: Vec<f64> = vec![0., 0., 1., 1., 1., 1.];
         let y_true: Vec<f64> = vec![0., 1., 1., 0., 1., 0.];
 
-        let score3: f64 = Recall {}.get_score(&y_pred, &y_true);
-        assert!((score3 - 0.66666666).abs() < 1e-8);
+        let score3: f64 = Recall::new().get_score(&y_pred, &y_true);
+        assert!((score3 - 0.6666666666666666).abs() < 1e-8);
     }
 
     #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test::wasm_bindgen_test)]
@@ -103,8 +121,8 @@ mod tests {
         let y_true: Vec<f64> = vec![0., 0., 0., 1., 1., 1., 2., 2., 2.];
         let y_pred: Vec<f64> = vec![0., 1., 2., 0., 1., 2., 0., 1., 2.];
 
-        let score1: f64 = Recall {}.get_score(&y_pred, &y_true);
-        let score2: f64 = Recall {}.get_score(&y_pred, &y_pred);
+        let score1: f64 = Recall::new().get_score(&y_pred, &y_true);
+        let score2: f64 = Recall::new().get_score(&y_pred, &y_pred);
 
         assert!((score1 - 0.333333333).abs() < 1e-8);
         assert!((score2 - 1.0).abs() < 1e-8);