remoe LabelDefinition, looks like unnecesery abstraction for now

src/preprocessing/target_encoders.rs

@@ -91,12 +91,31 @@ impl<'a, LabelType: Hash + Eq + Clone> OneHotEncoder<LabelType> {
     }
 
     /// Build an encoder from a predefined (label -> class number) map
-    pub fn from_label_map(labels: HashMap<LabelType, usize>) -> Self {
+    pub fn from_label_map(category_map: HashMap<CategoryType, usize>) -> Self {
-        Self::from_label_def(LabelDefinition::LabelToClsNumMap(labels))
+        let mut _unique_cat: Vec<(CategoryType, usize)> =
+            category_map.iter().map(|(k, v)| (k.clone(), *v)).collect();
+        _unique_cat.sort_by(|a, b| a.1.cmp(&b.1));
+        let categories: Vec<CategoryType> = _unique_cat.into_iter().map(|a| a.0).collect();
+        Self {
+            num_categories: categories.len(),
+            categories,
+            category_map,
     }
+    }
+
     /// Build an encoder from a predefined positional label-class num vector
-    pub fn from_positional_label_vec(labels: Vec<LabelType>) -> Self {
+    pub fn from_positional_label_vec(categories: Vec<CategoryType>) -> Self {
-        Self::from_label_def(LabelDefinition::PositionalLabel(labels))
+        // Self::from_label_def(LabelDefinition::PositionalLabel(categories))
+        let category_map: HashMap<CategoryType, usize> = categories
+            .iter()
+            .enumerate()
+            .map(|(v, k)| (k.clone(), v))
+            .collect();
+        Self {
+            num_categories: categories.len(),
+            category_map,
+            categories,
+        }
     }
 
     /// Transform a slice of label types into one-hot vectors